We see small primitive data everywhere

TL;DR: Don't forget to model the smallest ones

Problems

• Primitive obsession

Solutions

1. find responsibilities for small objects in the MAPPER

2. Reify them

Context

Since computing early days we map all we see to the familiar primitive data types: Strings, Integers, Collections, etc.

Mapping to dates violates abstraction and fail-fast principles.

in the Wordle TDD Kata, we describe a Wordle word to be different than a String or Char(5), since they don't have the same responsibilities.

Sample Code

Wrong

public class Person {
    private final String name; 

    public Person(String name) {
        this.name = name;
    }
}

Right

public class Name {
    private final String name; 

    public Name(String name) {
        this.name = name;
        // Name has its own creation rules, comparison etc.
        // Might be different than a string
    }
}

public class Person {
    private final Name name; 

    public Person(Name name) {
        // name is created as a valid one,
        // we don't need to add validations here 
        this.name = name;
    }
}

Detection

[X] Manual

This is a semantic smell. It is related to design activity

Exceptions

In a very small number of mission-critical systems, we have a tradeoff from abstraction to performance.

This is not the usual case. We do premature optimization not relying on a modern computer and virtual machine optimizations.

As always, we need to stick to evidence in real-world scenarios.

Tags

• Primitive

Conclusion

Finding small objects is a very hard task requiring experience to make a good job and avoid overdesign.

There's no silver bullet in choosing how and when to map something.

Relations

Code Smell 122 - Primitive Obsession

Maxi Contieri ・ Mar 17 '22

#oop #webdev #tutorial #beginners

More Info

Fail Fast

Maxi Contieri ・ Dec 6 '20

#codenewbie #programming #webdev #oop

How to Create a Wordle with TDD in Javascript

Maxi Contieri ・ Sep 13 '22

#javascript #programming #tutorial #tdd

Disclaimer

Code Smells are just my opinion.

Credits

Photo by Shane Aldendorff on Unsplash

The secret to building large apps is never build large apps. Break your applications into small pieces. Then, assemble those testable, bite-sized pieces into your big application.

Justin Meyer

Software Engineering Great Quotes

Maxi Contieri ・ Dec 28 '20

#codenewbie #programming #quotes #software

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code

Maxi Contieri ・ May 21 '21

#codenewbie #tutorial #codequality #beginners