Not operator is our friend. Not not operator is not our friend

Problems

• Readability

Solutions

1. Name your variables, methods and classes with positive names.

Sample Code

Wrong

Right

Detection

This is a semantic smell. We need to detect it on code reviews.

We can tell linters to check for Regular Expressions like !not or !isNot etc as a warning.

Tags

• Readability

Conclusion

Double negation is a very basic rule we learn as junior developers.

There are lots of production systems filled with this smell.

We need to trust our test coverage and make safe renames and other refactors.

Relations

Code Smell 24 - Boolean Coercions

Maxi Contieri ・ Nov 14 '20

#oop #tutorial #boolean #coercion

Code Smell 07 - Boolean Variables

Maxi Contieri ・ Oct 26 '20

#codenewbie #tutorial #beginners

Code Smell 06 - Too Clever Programmer

Maxi Contieri ・ Oct 25 '20

#codenewbie #tutorial #beginners

More info

Remove Double Negative

Boolean Methods

Credits

Photo by Daniel Herron on Unsplash

It’s harder to read code than to write it.

Joel Spolsky